Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use dynamicinformerfactory to get nodepool instead of yurt-app-manager-api repo #1652

Merged
merged 1 commit into from
Aug 15, 2023
Merged

use dynamicinformerfactory to get nodepool instead of yurt-app-manager-api repo #1652

merged 1 commit into from
Aug 15, 2023

Conversation

rambohe-ch
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

/kind feature

What this PR does / why we need it:

  1. remove dependencies on yurt-app-manager-api repo and yurt client repo
  2. use dynamic client and dynamicinformer to get NodePool resource
  3. update imports of v1alpha1.NodePool to v1beta1.NodePool

Which issue(s) this PR fixes:

Fixes #1010

Special notes for your reviewer:

Does this PR introduce a user-facing change?

other Note

@openyurt-bot
Copy link
Collaborator

@rambohe-ch: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

/kind feature

What this PR does / why we need it:

  1. remove dependencies on yurt-app-manager-api repo and yurt client repo
  2. use dynamic client and dynamicinformer to get NodePool resource
  3. update imports of v1alpha1.NodePool to v1beta1.NodePool

Which issue(s) this PR fixes:

Fixes #1010

Special notes for your reviewer:

Does this PR introduce a user-facing change?

other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added kind/feature kind/feature size/XL size/XL: 500-999 labels Aug 14, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.3% 1.3% Duplication

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added the approved approved label Aug 14, 2023
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #1652 (4917cbe) into master (2ed7f0f) will increase coverage by 0.00%.
The diff coverage is 53.19%.

@@           Coverage Diff           @@
##           master    #1652   +/-   ##
=======================================
  Coverage   51.66%   51.66%           
=======================================
  Files         145      145           
  Lines       17011    16977   -34     
=======================================
- Hits         8788     8772   -16     
+ Misses       7407     7393   -14     
+ Partials      816      812    -4
Flag Coverage Δ
unittests 51.66% <53.19%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/util/kubeconfig/kubeconfig.go 48.64% <ø> (-3.12%) ⬇️
pkg/yurtadm/cmd/join/join.go 58.33% <0.00%> (+0.95%) ⬆️
pkg/yurthub/filter/servicetopology/filter.go 70.38% <43.47%> (-2.68%) ⬇️
cmd/yurthub/app/config/config.go 51.64% <62.50%> (+2.66%) ⬆️
pkg/yurthub/filter/initializer/initializer.go 53.84% <66.66%> (ø)
pkg/yurthub/filter/manager/manager.go 85.48% <100.00%> (ø)
pkg/yurthub/filter/nodeportisolation/filter.go 86.04% <100.00%> (ø)

... and 1 file with indirect coverage changes

YTGhost
YTGhost reviewed Aug 15, 2023
View reviewed changes
Copy link
Member

@YTGhost YTGhost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openyurt-bot openyurt-bot added the lgtm lgtm label Aug 15, 2023
@openyurt-bot openyurt-bot merged commit 3dbb153 into openyurtio:master Aug 15, 2023
@open-digger-bot open-digger-bot bot mentioned this pull request Aug 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YTGhost YTGhost YTGhost left review comments

@fengshunli fengshunli Awaiting requested review from fengshunli

@luckymrwang luckymrwang Awaiting requested review from luckymrwang

Assignees

@YTGhost YTGhost

Labels
approved approved kind/feature kind/feature lgtm lgtm size/XL size/XL: 500-999
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feature request] deprecated repo yurt-app-manager-api
3 participants
@rambohe-ch @openyurt-bot @YTGhost